Of course Goodfellas glamorizes crime. The first chunk of the movie is like an episode of Entourage.
Which isn't to diminish the accomplishments of the movie, or say that's the only or primary goal, but it's certainly a big part of the appeal. If Scorcese made family dramas about the experiences of Catholics in America, he'd be a well respected indy director and not nearly as well known.
The rise-and-fall trajectory is a very biopic thing, and those generally bore me. Also, at certain points (the beginning of the last act in Goodfellas, the start of the movie in Casino), the movie gets fatalistic. Which isn't necessarily bad, but it feels a bit preachy to me in this context.
I'll freely admit that I'm biased towards tight plotting and reflexively roll my eyes when I hear a movie "really captures that time and place." I want a story, dammit, not a postcard.