Okay. So instead of bitching about what you guys think are bad controllers, everyone tell me what your favorite controller is so I can ridicule you mercilessly.
I'll go first
-Sega Saturn
I want to say the CC Pro, because I do love it like a waifu, but if I'm being honest with myself, it's GameCube. Not the Wavebird, which has very very slightly poorer ergonomics and no rumble and a lack of weight, but the actual corded controller (which I do wish was uncorded, for the record.) Perfect weight, perfect ergonomics, powerful rumble.
Perfect overall? No. No nonono. D-pad is crap, c-stick is crap, Z button and no left Z button are sucky, but... it melts into my hands. I also don't mind the button configuration, but that's because most Nintendo games were built around it (obviously) instead of shoehorning a PS2 scheme onto it.
CC Pro is, obviously, second. Perfect d-pad, perfect buttons, the best to-date analog sticks (and two of them!) Nintendo had made, great shoulder buttons, near-perfect ergonomics. But, of course, no rumble and not truly wireless. Both things the Pro Controller seems to fix without taking any steps back (the switched stick position is a step sideways, I think.)
So I'm very keen to spend some quality time with the Protroller, since it's in the running to surpass both the GC and CC Pro for me.