We both flat out told each other we love each other.
And I do resent her a bit for passing me up for a heroin addict who can’t hold a job for more than a few months...
But hey, we all make mistakes. All shall be forgiven once that relationship meets its inevitable end and she eventually comes around to me.
And if not then she’ll become one of many acquaintances that I’m friendly to but not super close with.

OK, sorry to be theBore-ing Dad, but here goes:
This is utterly standard, bullshit, Good Guy behavior. She's broken. She's in a broken relationship. You're waiting until she realizes you're a better choice.
Straight up, this is not what it means to be a decent person. Nothing good can come of this.
You're broken, too. You can choose to work on that, or just find another broken person who fulfills your expectations of the universe, which is what this looks like from here.